launchpad-reviewers team mailing list archive

[Colin Watson <mp+442912@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds into launchpad:master.

Commit message:
Unexport Snap.getBuildSummariesForSnapBuildIds

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442912

In https://code.launchpad.net/~cjwatson/launchpad/snap-request-builds-ui/+merge/348299, I wrote "Deprecated as an exported method; can become an internal helper method once production JavaScript no longer uses it" above `Snap.getBuildSummariesForSnapBuildIds` ... and then promptly forgot about it for nearly five years.  Finish this off.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds into launchpad:master.

diff --git a/lib/lp/snappy/interfaces/snap.py b/lib/lp/snappy/interfaces/snap.py
index fe9b768..f8e6505 100644
--- a/lib/lp/snappy/interfaces/snap.py
+++ b/lib/lp/snappy/interfaces/snap.py
@@ -597,16 +597,6 @@ class ISnapView(Interface):
         )
     )
 
-    # XXX cjwatson 2018-06-20: Deprecated as an exported method; can become
-    # an internal helper method once production JavaScript no longer uses
-    # it.
-    @operation_parameters(
-        snap_build_ids=List(
-            title=_("A list of snap build IDs."), value_type=Int()
-        )
-    )
-    @export_read_operation()
-    @operation_for_version("devel")
     def getBuildSummariesForSnapBuildIds(snap_build_ids):
         """Return a dictionary containing a summary of the build statuses.