launchpad-reviewers team mailing list archive

[Colin Watson <mp+442957@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:remove-zope.securitypolicy into launchpad:master.

Commit message:
Remove zope.securitypolicy

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442957

When looking over our Zope dependencies, I happened to notice that we don't really use `zope.securitypolicy`: its `meta.zcml` registers four ZCML directives, none of which we use, and we don't import anything from it anywhere else.  We can just drop it.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:remove-zope.securitypolicy into launchpad:master.

diff --git a/setup.cfg b/setup.cfg
index be574c6..372b8f8 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -154,7 +154,6 @@ install_requires =
     zope.publisher
     zope.schema
     zope.security
-    zope.securitypolicy
     zope.sendmail
     zope.tal
     zope.tales
diff --git a/zcml/zopeapp.zcml b/zcml/zopeapp.zcml
index 16cc755..212166b 100644
--- a/zcml/zopeapp.zcml
+++ b/zcml/zopeapp.zcml
@@ -14,7 +14,6 @@
   <include package="zope.publisher" file="meta.zcml" />
   <include package="zope.browsermenu" file="meta.zcml" />
   <include package="zope.browserpage" file="meta.zcml" />
-  <include package="zope.securitypolicy" file="meta.zcml" />
   <include package="zope.sendmail" file="meta.zcml" />
   <include package="zope.app.publication" file="meta.zcml" />
   <include package="zope.app.publisher.xmlrpc" file="meta.zcml" />