launchpad-reviewers team mailing list archive

[Colin Watson <mp+442972@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-doc-migration-wording into launchpad:master.

Commit message:
charm: Tidy up wording for librarian's active=false mode

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442972

Responding to a review comment in https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442615.  I don't really want to describe this as a read-only mode with exceptions, but perhaps this is clearer.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:charm-librarian-doc-migration-wording into launchpad:master.

diff --git a/charm/launchpad-librarian/README.md b/charm/launchpad-librarian/README.md
index bd2a657..52ab88c 100644
--- a/charm/launchpad-librarian/README.md
+++ b/charm/launchpad-librarian/README.md
@@ -30,12 +30,11 @@ Only one instance of the librarian may be active at any one time, and very
 little downtime is acceptable on production.  This means that we have to be
 especially careful when redeploying.  The general procedure is as follows:
 
-1. Deploy a new unit with `active=false`.  This will run the librarian in
-   more or less a read-only mode: downloads are possible, and cron jobs that
-   would modify the database, the contents of the librarian, or the contents
-   of Swift are disabled.  If uploads happen they will be spooled locally,
-   but that's low-risk since only Launchpad itself uploads to the librarian.
-   This allows testing connectivity.
+1. Deploy a new unit with `active=false`.  This will disable periodic jobs
+   that would modify the database, the contents of the librarian, or the
+   contents of Swift.  Downloads are possible, and if uploads happen they
+   will be spooled locally, but that's low-risk since only Launchpad itself
+   uploads to the librarian.  This mode allows testing connectivity.
 
 1. Ensure that a Ceph volume is mounted persistently on
    `/srv/launchpad/librarian/`.  On production this should be a 2 TiB volume