launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+443367@xxxxxxxxxxxxxxxxxx>]

Thanks for your contribution!

Could you please add an entry in the NEWS.rst?

Also, `bases.BuilddBaseAlias.DEVEL` was only introduced in craft-providers 1.8.1, but our `requirements.in` specify 1.8.0 as minimum version. Could you please update the minimum required version and the comment?

I do not think we need to apply `tox -e pip-compile` now, as version 1.8.1 was used in the requirements.txt anyway - but we (Launchapd devs) should update the dependencies soon.

I do feel a bit uneasy about adding code without tests, but that is the way we did before for adding new series/versions.

A very simple test that verifies that the key is present in `SERIES_TO_BUILDD_IMAGE_ALIAS` and that it maps to the correct image looks like it would not help too much, but at least it guarantees that we do not remove a series by mistake.

Do you want to add such a test? Do not worry if not, then I think I will add one for all series.
-- 
https://code.launchpad.net/~corey.bryant/lpci/+git/lpci/+merge/443367
Your team Launchpad code reviewers is requested to review the proposed merge of ~corey.bryant/lpci:main into lpci:main.