launchpad-reviewers team mailing list archive

[Colin Watson <mp+444201@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:charm-librarian-worker-count-change into launchpad:master.

Commit message:
charm/launchpad-librarian: Restart when worker count is changed

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444201

If the `workers` config option is changed in isolation, then none of the files currently checked for changes by the `configure` hook are changed, so it fails to restart the service to start up the new workers.  Avoid this problem by adding `/lib/systemd/system-generators/launchpad-librarian-generator` to the list of monitored files.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:charm-librarian-worker-count-change into launchpad:master.

diff --git a/charm/launchpad-librarian/reactive/launchpad-librarian.py b/charm/launchpad-librarian/reactive/launchpad-librarian.py
index 67cc398..2fe4630 100644
--- a/charm/launchpad-librarian/reactive/launchpad-librarian.py
+++ b/charm/launchpad-librarian/reactive/launchpad-librarian.py
@@ -129,6 +129,7 @@ def configure():
             base.version_info_path(),
             "/lib/systemd/system/launchpad-librarian.service",
             "/lib/systemd/system/launchpad-librarian@.service",
+            "/lib/systemd/system-generators/launchpad-librarian-generator",
         ]
         + config_files()
     ):