launchpad-reviewers team mailing list archive

[Peter Makowski <mp+444621@xxxxxxxxxxxxxxxxxx>]

Peter Makowski has proposed merging ~petermakowski/launchpad:set-font-color-#000 into launchpad:master.

Commit message:
set body font color to #000

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444621

set body font color to #000 as suggested by Vanilla framework team.

This increases colour contrast and is likely to improve font rendering that's been reported to cause issues for some users.

## Before
https://share.cleanshot.com/CZRm3XQB

## After
https://share.cleanshot.com/xCf8bMVz
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~petermakowski/launchpad:set-font-color-#000 into launchpad:master.

diff --git a/lib/canonical/launchpad/icing/css/base.scss b/lib/canonical/launchpad/icing/css/base.scss
index a28ec5d..970fce5 100644
--- a/lib/canonical/launchpad/icing/css/base.scss
+++ b/lib/canonical/launchpad/icing/css/base.scss
@@ -6,7 +6,7 @@ body {
                  sans-serif;
     font-size: 0.8rem;
     line-height: 1.2rem;
-    color: #333;
+    color: #000;
 
     &.private, &.public {
       /* It must be obvious to the user that the context is private */