← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ines-almeida/txpkgupload:remove-git-dependency-from-default-make-command into txpkgupload:master

 

Looking at https://git.launchpad.net/launchpad/commit?id=e13a516043 as an example, could you instead do `[ ! -d .git ] || scripts/update-version-info.sh`?  That should make it work gracefully in a charm, and I think you could probably then drop the change to the `build-tarball` rule.
-- 
https://code.launchpad.net/~ines-almeida/txpkgupload/+git/txpkgupload/+merge/444912
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/txpkgupload:remove-git-dependency-from-default-make-command into txpkgupload:master.



References