launchpad-reviewers team mailing list archive

[Guruprasad <mp+445031@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/subscribers/bugactivity.py b/lib/lp/bugs/subscribers/bugactivity.py
> index c036186..d1d1bc8 100644
> --- a/lib/lp/bugs/subscribers/bugactivity.py
> +++ b/lib/lp/bugs/subscribers/bugactivity.py
> @@ -66,6 +66,10 @@ def what_changed(object_modified_event):
>      after = object_modified_event.object
>      fields = object_modified_event.edited_fields
>      changes = {}
> +
> +    if not fields:

How is there a scenario when the object is modified without there being any fields that were edited?

> +        return changes
> +
>      for fieldname in fields:
>          # XXX 2011-01-21 gmb bug=705955:
>          #     Sometimes, something (webservice, I'm looking at you


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/445031
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:add-bug-webhooks/fix-failing-tests into launchpad:master.