launchpad-reviewers team mailing list archive

[Ines Almeida <mp+445653@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:add-missing-webhook-table-permissions into launchpad:master.

Commit message:
Add missing permissions to the webhook and webhookjob tables

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/445653

As described in https://wiki.canonical.com/InformationInfrastructure/OSA/LP/DeploymentIssues/2023-06-28-database-permissions-missing, there were some missing permissions that some builders had to access the `webhook` and the `webhookjob` tables, which led to failures when updating bugs because they couldn't query the `webhook` table.

This should add all the missing permissions.

I will later open a second MP that will ensure unit tests run with the bug webhooks enabled so can actually verify we are not missing any more permissions.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:add-missing-webhook-table-permissions into launchpad:master.

diff --git a/database/schema/security.cfg b/database/schema/security.cfg
index c48a956..c882f43 100644
--- a/database/schema/security.cfg
+++ b/database/schema/security.cfg
@@ -698,6 +698,8 @@ public.teammembership                   = SELECT
 public.teamparticipation                = SELECT, INSERT
 public.validpersoncache                 = SELECT
 public.validpersonorteamcache           = SELECT
+public.webhook                          = SELECT
+public.webhookjob                       = SELECT, INSERT
 public.wikiname                         = SELECT, INSERT
 public.xref                             = SELECT, INSERT
 type=user
@@ -1004,6 +1006,8 @@ public.structuralsubscription           = SELECT
 public.translationgroup                 = SELECT
 public.validpersoncache                 = SELECT
 public.validpersonorteamcache           = SELECT
+public.webhook                          = SELECT
+public.webhookjob                       = SELECT, INSERT
 public.xref                             = SELECT, INSERT
 type=user
 
@@ -1763,6 +1767,8 @@ public.teammembership                   = SELECT
 public.teamparticipation                = SELECT
 public.validpersoncache                 = SELECT
 public.validpersonorteamcache           = SELECT
+public.webhook                          = SELECT
+public.webhookjob                       = SELECT, INSERT
 public.xref                             = SELECT
 type=user
 
@@ -1977,6 +1983,8 @@ public.teammembership                   = SELECT
 public.teamparticipation                = SELECT
 public.validpersoncache                 = SELECT
 public.validpersonorteamcache           = SELECT
+public.webhook                          = SELECT
+public.webhookjob                       = SELECT, INSERT
 public.xref                             = SELECT, INSERT
 type=user