launchpad-reviewers team mailing list archive

[Colin Watson <mp+445980@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:snap-base-features-stale-comment into launchpad:master.

Commit message:
snappy: Remove stale XXX comment

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/445980

This was fixed in https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431544.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:snap-base-features-stale-comment into launchpad:master.

diff --git a/lib/lp/snappy/adapters/buildarch.py b/lib/lp/snappy/adapters/buildarch.py
index d2dc8fd..bd36747 100644
--- a/lib/lp/snappy/adapters/buildarch.py
+++ b/lib/lp/snappy/adapters/buildarch.py
@@ -226,10 +226,6 @@ def determine_architectures_to_build(
         # architecture; this is ambiguous and forbidden by snapcraft prior
         # to core22. Checking this here means that we don't get duplicate
         # supported_arch results below.
-
-        # XXX andrey-fedoseev 2022-08-22: we should use the `SnapBase` model
-        # to store the specific features of each base rather than hard-coding
-        # the base names here
         build_ons = Counter()
         for arch in architectures:
             build_ons.update(arch.build_on)