launchpad-reviewers team mailing list archive

[Colin Watson <mp+446153@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:core24 into launchpad:master.

Commit message:
Add core24 as a permitted core snap name

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #2012405 in Launchpad itself: "Support for core24 base"
  https://bugs.launchpad.net/launchpad/+bug/2012405

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/446153

`core24` exists in the store now, though only in the edge channel, so this allows snap recipes that use it as a base to specify a channel for it.  (This would presumably only be used for experimentation or for special cases, until this base is officially released.)
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:core24 into launchpad:master.

diff --git a/lib/lp/services/fields/__init__.py b/lib/lp/services/fields/__init__.py
index 13bbc6c..a4a919a 100644
--- a/lib/lp/services/fields/__init__.py
+++ b/lib/lp/services/fields/__init__.py
@@ -1012,7 +1012,7 @@ class InlineObject(Object):
 class SnapBuildChannelsField(Dict):
     """A field that holds source snap channels for builds."""
 
-    _core_snap_names = ["core", "core18", "core20", "core22"]
+    _core_snap_names = ["core", "core18", "core20", "core22", "core24"]
 
     def __init__(
         self,