launchpad-reviewers team mailing list archive

[Ines Almeida <mp+446202@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/txpkgupload:update-build-tarball-command into txpkgupload:master.

Commit message:
Add version-info command to build-tarball

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/txpkgupload/+git/txpkgupload/+merge/446202

Build failed because we are not running neither `make` before which is where `version-info.py` gets created. Adding a line to add the `version-info` on build tarball (which sees like a sensible place to run it)
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/txpkgupload:update-build-tarball-command into txpkgupload:master.

diff --git a/Makefile b/Makefile
index 3719e19..55d04d0 100644
--- a/Makefile
+++ b/Makefile
@@ -106,6 +106,7 @@ build-tarball:
 	@echo "Creating deployment tarball at $(TARBALL_BUILD_PATH)"
 	rm -rf $(ENV)
 	$(MAKE) $(ENV)
+	$(MAKE) $(VERSION_INFO)
 	$(PIP) wheel -f $(DEPENDENCY_DIR) --no-index -w $(WHEELS) \
 		-r bootstrap-requirements.txt -r requirements.txt
 	mkdir -p $(TARBALL_BUILD_DIR)