← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ines-almeida/txpkgupload:refactor-makefile-commands into txpkgupload:master

 


Diff comments:

> diff --git a/Makefile b/Makefile
> index 55d04d0..bc69913 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -105,8 +109,7 @@ clean: clean_pip
>  build-tarball:
>  	@echo "Creating deployment tarball at $(TARBALL_BUILD_PATH)"
>  	rm -rf $(ENV)
> -	$(MAKE) $(ENV)
> -	$(MAKE) $(VERSION_INFO)
> +	$(MAKE) boorstrap

`s/boorstrap/bootstrap`

>  	$(PIP) wheel -f $(DEPENDENCY_DIR) --no-index -w $(WHEELS) \
>  		-r bootstrap-requirements.txt -r requirements.txt
>  	mkdir -p $(TARBALL_BUILD_DIR)


-- 
https://code.launchpad.net/~ines-almeida/txpkgupload/+git/txpkgupload/+merge/446311
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/txpkgupload:refactor-makefile-commands into txpkgupload:master.



References