launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

To: Loïc Minier <loic.minier@xxxxxxxxxx>
From: Richard Hansen <mp+443942@xxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Jul 2023 06:28:17 -0000
In-reply-to: <168561037641.16643.16050971481846563027.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+443942@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I opened an alternative merge request [1] that is the same as this one except:
  - Tags are put in refs/tags/<remote>/* instead of refs/remotes/<remote>/* (to avoid potential name collisions).
  - I added some comments explaining why fetching is done the way it is.
  - I added tests.

[1] https://code.launchpad.net/~rhansen/git-build-recipe/+git/git-build-recipe/+merge/446358
-- 
https://code.launchpad.net/~lool/git-build-recipe/+git/git-build-recipe/+merge/443942
Your team Launchpad code reviewers is requested to review the proposed merge of ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master.

References

[Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master
From: Loïc Minier, 2023-06-01