launchpad-reviewers team mailing list archive

[Colin Watson <mp+446377@xxxxxxxxxxxxxxxxxx>]

This seems unnecessarily complicated.  `PIP_FIND_LINKS` can take multiple entries, and it isn't a problem if one of them doesn't exist.

Instead of this change, what happens if you:

 * add `--extra-search-dir=$(CURDIR)/wheels/ --extra-search-dir=$(DEPENDENCY_DIR)/` to the `$(VIRTUALENV)` command
 * change `PIP_FIND_LINKS=file://$(DEPENDENCY_DIR)/` to `PIP_FIND_LINKS="file://$(CURDIR)/wheels/ file://$(DEPENDENCY_DIR)/"`

?  I think that should work, and it's more in line with how Launchpad itself does things.
-- 
https://code.launchpad.net/~ines-almeida/txpkgupload/+git/txpkgupload/+merge/446377
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/txpkgupload:refactor-makefile-commands into txpkgupload:master.