launchpad-reviewers team mailing list archive

[Guruprasad <mp+446758@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/charm/launchpad-scripts/templates/crontab.j2 b/charm/launchpad-scripts/templates/crontab.j2
> index d0c0072..cdcc68e 100644
> --- a/charm/launchpad-scripts/templates/crontab.j2
> +++ b/charm/launchpad-scripts/templates/crontab.j2
> @@ -31,7 +31,7 @@ LPCONFIG=launchpad-scripts
>  27 07 * * 3 {{ code_dir }}/cronscripts/rosetta-pofile-stats.py -q --log-file=INFO:{{ logs_dir }}/rosetta-pofile-stats.log
>  
>  # Debian bugs mirroring, used by checkwatches
> -4,19,34,49 * * * * {{ code_dir }}/scripts/debbugs-sync >>{{ logs_dir }}/debbugs-sync.log 2>&1
> +4,19,34,49 * * * * {{ code_dir }}/scripts/debbugs-sync {{ base_dir }}/debbugs_db >> {{ logs_dir }}/debbugs-sync.log 2>&1

The script cannot create a directory under the `base_dir` directory because of missing permissions. Should I use a different directory with write permissions like `{{ var_dir }}/debbugs_db` instead?

>  
>  # NB. checkwatches requires access to /srv/bugs-mirror.debian.org/
>  # Reverted to doing ten at a time (--jobs=10) as https://bugs.launchpad.net/bugs/435952 should be fixed


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/446758
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:tweak-debbugs-sync-script into launchpad:master.