launchpad-reviewers team mailing list archive

[Guruprasad <mp+447561@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:launchpad-scripts-configuration-enable-debian-bugs-mirroring into launchpad:master.

Commit message:
charm/launchpad-scripts: Add configuration to enable Debian bugs mirror

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/447561
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:launchpad-scripts-configuration-enable-debian-bugs-mirroring into launchpad:master.

diff --git a/charm/launchpad-scripts/config.yaml b/charm/launchpad-scripts/config.yaml
index 5abcb52..6f79540 100644
--- a/charm/launchpad-scripts/config.yaml
+++ b/charm/launchpad-scripts/config.yaml
@@ -11,6 +11,13 @@ options:
     type: string
     description: YAML-encoded dict mapping the credentials name to values.
     default: "{}"
+  enable_debian_bugs_mirroring:
+    type: boolean
+    description: |
+      Should the Debian bug data mirroring job be enabled? Disabling this
+      will also disable the checkwatches script which depends on the mirrored
+      Debian bug data.
+    default: false
   language_pack_exporter_schedule:
     type: string
     description: >-
diff --git a/charm/launchpad-scripts/templates/crontab.j2 b/charm/launchpad-scripts/templates/crontab.j2
index 27a29e2..2a45014 100644
--- a/charm/launchpad-scripts/templates/crontab.j2
+++ b/charm/launchpad-scripts/templates/crontab.j2
@@ -30,6 +30,8 @@ LPCONFIG=launchpad-scripts
 
 27 07 * * 3 {{ code_dir }}/cronscripts/rosetta-pofile-stats.py -q --log-file=INFO:{{ logs_dir }}/rosetta-pofile-stats.log
 
+{%- if enable_debian_bugs_mirroring %}
+
 # Debian bugs mirroring, used by checkwatches
 4,19,34,49 * * * * {{ code_dir }}/scripts/debbugs-sync {{ var_dir }}/debbugs-mirror >> {{ logs_dir }}/debbugs-sync.log 2>&1
 
@@ -39,6 +41,8 @@ LPCONFIG=launchpad-scripts
 # Compress old checkwatches logs
 5 0 * * * find {{ logs_dir }}/checkwatches -maxdepth 1 -name '*.log' -type f -mtime +5 -print0 | xargs -0 -r nice gzip
 
+{%- endif %}
+
 # Rosetta
 */10 * * * * nice -16 {{ code_dir }}/cronscripts/rosetta-approve-imports.py -q --log-file=INFO:{{ logs_dir }}/rosetta-approve-imports.log
 */4 * * * * {{ code_dir }}/cronscripts/rosetta-export-queue.py -q --log-file=INFO:{{ logs_dir }}/rosetta-export-queue.log