launchpad-reviewers team mailing list archive

[Colin Watson <mp+447655@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:charm-doc-librarian-type into launchpad:master.

Commit message:
charm: Document production librarian volume type

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/447655

In PS5, we need to keep the librarian's local spool on fast Ceph (NVMe) for performance.  Document this for the next redeployment.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:charm-doc-librarian-type into launchpad:master.

diff --git a/charm/launchpad-librarian/README.md b/charm/launchpad-librarian/README.md
index 99e7701..8c116c8 100644
--- a/charm/launchpad-librarian/README.md
+++ b/charm/launchpad-librarian/README.md
@@ -44,7 +44,8 @@ especially careful when redeploying.  The general procedure is as follows:
 1. Create a Ceph volume for locally-spooled librarian data.  On production
    this should be a 2 TiB volume to allow some breathing room if uploading
    to Swift is temporarily unavailable: `openstack volume create --size 2048
-   --description 'spooled production librarian data' librarian-data`.
+   --type Ceph_NVMe --description 'spooled production librarian data'
+   librarian-data`.
 
 1. Attach this Ceph volume to the new unit using `openstack server add
    volume`.