launchpad-reviewers team mailing list archive

[Peter Makowski <mp+447200@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~petermakowski/launchpad:update-diff-view-ui into launchpad:master has been updated.

Description changed to:

## Screenshots
### Before
https://share.cleanshot.com/Mt1hRNg1
### After
https://share.cleanshot.com/5vxZHXRT

## Background color change
The change to background colors is indeed prompted by accessibility concerns. Higher contrast makes the text easier to read.

Both colors are exactly the same colors that are currently used on GitHub for the background for added and removed lines of code.

Currently removed lines fail WCAG 2.0 accessibility test entirely. After this change text passes a WCAG accessibility check with level AAA (the strictest accessibility check).

Comparison of color contrast before and after this change:

type of line | WCAG 2.0 score before | WCAG 2.0 score after
removed | Failed (ratio 2.80)  | Passed AAA (ratio 11.32)
added | Passed AA (4.99) | Passed AAA (9.25)

(AA is a strict, and AAA the strictest accessibility check)

You can verify the above yourself e.g. using the WEBAIM Contrast Checker: https://webaim.org/resources/contrastchecker/

For more details, see:
https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/447200
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~petermakowski/launchpad:update-diff-view-ui into launchpad:master.