launchpad-reviewers team mailing list archive

[Peter Makowski <mp+447200@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~petermakowski/launchpad:update-diff-view-ui into launchpad:master has been updated.

Description changed to:

## Screenshots
### Before
https://share.cleanshot.com/Mt1hRNg1
### After
https://share.cleanshot.com/5vxZHXRT

## Background color change
The change to background colors is indeed prompted by accessibility concerns. Higher contrast makes the text easier to read.

Comparison of color contrast before and after this change:

WCAG 2.0 ratio (the higher, the better)
type of line |  before  | after
removed | 7.31  | 11.32
added | 14.41 | 17.54

APCA (the higher, the better)
type of line | before | after
removed | Lc 50.3  | Lc 69.4
added | Lc 83.5 | Lc 94.3

You can verify the above yourself e.g. using the WEBAIM Contrast Checker: https://webaim.org/resources/contrastchecker/
and APCA: https://www.myndex.com/APCA/?BG=ff7f7f&TXT=000000&DEV=G4g&BUF=A22
https://www.myndex.com/APCA/?BG=92ed92&TXT=000000&DEV=G4g&BUF=A22

For more details, see:
https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/447200
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~petermakowski/launchpad:update-diff-view-ui into launchpad:master.