launchpad-reviewers team mailing list archive

[Ines Almeida <mp+447663@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py b/lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py
> index 7e8dc23..bee39fd 100644
> --- a/lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py
> +++ b/lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py
> @@ -13,7 +13,7 @@ class HtaccessTokenGenerator(LaunchpadCronScript):
>      # generate .htaccess or .htpasswd files, but instead check archive
>      # authentication dynamically; and garbo now handles expiring
>      # subscriptions and deactivating tokens.  We can remove this script once
> -    # we stop running it on production.
> +    # after `launchpad-ppa-publisher` charm is deployed to production

Added this just to give it a more specific time period to remove later

>  
>      def add_my_options(self):
>          """Add script command line options."""


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/447663
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:add-ppa-publisher-charm into launchpad:master.