← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~xnox/launchpad:snap-request-builds-mimick-auto into launchpad:master

To: Dimitri John Ledkov <dimitri.ledkov+lp@xxxxxxxxxxxxx>
From: Colin Watson <mp+447665@xxxxxxxxxxxxxxxxxx>
Date: Wed, 30 Aug 2023 14:28:15 -0000
In-reply-to: <169030489507.7788.1474580451006774611.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+447665@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I'm not sure it necessarily makes sense for us to look at this before you write some tests.  I think I'm OK with the approach in principle.
-- 
https://code.launchpad.net/~xnox/launchpad/+git/launchpad/+merge/447665
Your team Launchpad code reviewers is requested to review the proposed merge of ~xnox/launchpad:snap-request-builds-mimick-auto into launchpad:master.

References

[Merge] ~xnox/launchpad:snap-request-builds-mimick-auto into launchpad:master
From: Dimitri John Ledkov, 2023-07-25