launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~cjwatson/launchpad:initializedistroseriesjob-parent-str into launchpad:master

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Jürgen Gmach <mp+451066@xxxxxxxxxxxxxxxxxx>
Date: Mon, 11 Sep 2023 07:02:48 -0000
In-reply-to: <169435057691.1888531.14306888218661107096.launchpad@juju-98d295-prod-launchpad-17>
Reply-to: mp+451066@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

My first reaction was to ask you to add a comment to the tests that explain that we expect the IDs as strings.

It seems very tedious and repetitive, but I still think it would be a good idea to add comments. Tests should be as straight forward as possible, and here we need to apply a workaround for a questionable design decision.

Please add a short comment to all occasions.
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/451066
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:initializedistroseriesjob-parent-str into launchpad:master.

References

[Merge] ~cjwatson/launchpad:initializedistroseriesjob-parent-str into launchpad:master
From: Colin Watson, 2023-09-10