launchpad-reviewers team mailing list archive

[Colin Watson <mp+451589@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:pre-commit-pin-node into launchpad:master.

Commit message:
pre-commit: Pin node to 20.6.1

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/451589

20.7.0 was released today, and the included version of npm doesn't seem to manage to talk to the proxy correctly in Launchpad CI builds any more.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:pre-commit-pin-node into launchpad:master.

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index eafc49d..0c51a41 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -65,6 +65,9 @@ repos:
     hooks:
     -   id: eslint
         args: [--quiet]
+        # 20.7.0 upgraded from npm 9.8.1 to 10.1.0, which appears to fail to
+        # use the proxy correctly in Launchpad CI builds.
+        language_version: "20.6.1"
 -   repo: https://github.com/keewis/blackdoc
     rev: v0.3.8
     hooks: