launchpad-reviewers team mailing list archive

[Colin Watson <mp+451729@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/rutabaga:charm-build-packages into rutabaga:master.

Commit message:
charm: Add python3-dev to build-packages

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/rutabaga/+git/rutabaga/+merge/451729

Without this, Cython failed to build in a Launchpad charm recipe build.  (I missed this locally, perhaps because a built wheel was cached somewhere.)
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/rutabaga:charm-build-packages into rutabaga:master.

diff --git a/charm/rutabaga-auth-helper/charmcraft.yaml b/charm/rutabaga-auth-helper/charmcraft.yaml
index 49bca9e..90117f7 100644
--- a/charm/rutabaga-auth-helper/charmcraft.yaml
+++ b/charm/rutabaga-auth-helper/charmcraft.yaml
@@ -79,6 +79,7 @@ parts:
     source: .
     plugin: reactive
     build-snaps: [charm]
+    build-packages: [python3-dev]
     build-environment:
       - CHARM_LAYERS_DIR: $CRAFT_STAGE/layers/layer
       - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
diff --git a/charm/rutabaga/charmcraft.yaml b/charm/rutabaga/charmcraft.yaml
index 4fc48b8..f4664c7 100644
--- a/charm/rutabaga/charmcraft.yaml
+++ b/charm/rutabaga/charmcraft.yaml
@@ -90,6 +90,7 @@ parts:
     source: .
     plugin: reactive
     build-snaps: [charm]
+    build-packages: [python3-dev]
     build-environment:
       - CHARM_LAYERS_DIR: $CRAFT_STAGE/layers/layer
       - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface