← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~ines-almeida/launchpad:increase-signing-tests-timeout into launchpad:master

 

Ines Almeida has proposed merging ~ines-almeida/launchpad:increase-signing-tests-timeout into launchpad:master.

Commit message:
Increase timeout of signing tests from 30 to 45 seconds
    
Some tests are consistently failing during builds with a timeout error, even though they don't seem stuck - they just might take a few seconds longer. This will help make the builder more stable.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/452093
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:increase-signing-tests-timeout into launchpad:master.
diff --git a/lib/lp/archivepublisher/tests/test_sync_signingkeys.py b/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
index 3c73754..d8a955b 100644
--- a/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
+++ b/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
@@ -53,7 +53,7 @@ from lp.testing.script import run_script
 
 class TestSyncSigningKeysScript(TestCaseWithFactory):
     layer = ZopelessDatabaseLayer
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=30)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=45)
 
     def setUp(self):
         super().setUp()

Follow ups