launchpad-reviewers team mailing list archive

[Colin Watson <mp+452116@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:charm-ppa-binary-wheels into launchpad:master.

Commit message:
charm: Build PPA publisher/uploader with binary wheels

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/452116

This avoids needing things like `libpq-dev` to be installed before we can start executing charm code, and it matches all our other charms.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:charm-ppa-binary-wheels into launchpad:master.

diff --git a/charm/launchpad-ppa-publisher/charmcraft.yaml b/charm/launchpad-ppa-publisher/charmcraft.yaml
index 76dc78c..13d0d15 100644
--- a/charm/launchpad-ppa-publisher/charmcraft.yaml
+++ b/charm/launchpad-ppa-publisher/charmcraft.yaml
@@ -73,3 +73,4 @@ parts:
       - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
       - PIP_NO_INDEX: "true"
       - PIP_FIND_LINKS: $CRAFT_STAGE/charm-wheels
+    reactive-charm-build-arguments: [--binary-wheels-from-source]
diff --git a/charm/launchpad-ppa-uploader/charmcraft.yaml b/charm/launchpad-ppa-uploader/charmcraft.yaml
index 4ff69d8..392d3ad 100644
--- a/charm/launchpad-ppa-uploader/charmcraft.yaml
+++ b/charm/launchpad-ppa-uploader/charmcraft.yaml
@@ -61,3 +61,4 @@ parts:
       - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
       - PIP_NO_INDEX: "true"
       - PIP_FIND_LINKS: $CRAFT_STAGE/charm-wheels
+    reactive-charm-build-arguments: [--binary-wheels-from-source]