← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~lgp171188/launchpad:remove-unused-demo-charm-code into launchpad:master

 

Guruprasad has proposed merging ~lgp171188/launchpad:remove-unused-demo-charm-code into launchpad:master.

Commit message:
charm/launchpad: Remove the unused charm code

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/452219
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:remove-unused-demo-charm-code into launchpad:master.
diff --git a/charm/launchpad/charmcraft.yaml b/charm/launchpad/charmcraft.yaml
deleted file mode 100644
index 60c2c7b..0000000
--- a/charm/launchpad/charmcraft.yaml
+++ /dev/null
@@ -1,62 +0,0 @@
-type: charm
-bases:
-  - build-on:
-    - name: ubuntu
-      channel: "20.04"
-      architectures: [amd64]
-    run-on:
-    - name: ubuntu
-      channel: "20.04"
-      architectures: [amd64]
-parts:
-  charm-wheels:
-    source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels
-    source-commit: "42c89d9c66dbe137139b047fd54aed49b66d1a5e"
-    source-submodules: []
-    source-type: git
-    plugin: dump
-    organize:
-      "*": charm-wheels/
-    prime:
-      - "-charm-wheels"
-  ols-layers:
-    source: https://git.launchpad.net/ols-charm-deps
-    source-commit: "9c59a9804f1f40e2a74be7dac9bf18a655a7864f"
-    source-submodules: []
-    source-type: git
-    plugin: dump
-    organize:
-      "*": layers/
-    stage:
-      - layers
-    prime:
-      - "-layers"
-  launchpad-layers:
-    after:
-      - ols-layers
-    source: https://git.launchpad.net/launchpad-layers
-    source-commit: "6ca1d670f636e1abb8328d88fc5fda80cb75152a"
-    source-submodules: []
-    source-type: git
-    plugin: dump
-    organize:
-      launchpad-base: layers/layer/launchpad-base
-      launchpad-payload: layers/layer/launchpad-payload
-    stage:
-      - layers
-    prime:
-      - "-layers"
-  charm:
-    after:
-      - charm-wheels
-      - launchpad-layers
-    source: .
-    plugin: reactive
-    build-snaps: [charm]
-    build-packages: [libpq-dev, python3-dev]
-    build-environment:
-      - CHARM_LAYERS_DIR: $CRAFT_STAGE/layers/layer
-      - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
-      - PIP_NO_INDEX: "true"
-      - PIP_FIND_LINKS: $CRAFT_STAGE/charm-wheels
-    reactive-charm-build-arguments: [--binary-wheels-from-source]
diff --git a/charm/launchpad/layer.yaml b/charm/launchpad/layer.yaml
deleted file mode 100644
index bcff867..0000000
--- a/charm/launchpad/layer.yaml
+++ /dev/null
@@ -1,3 +0,0 @@
-includes:
-  - layer:launchpad-base
-repo: https://git.launchpad.net/launchpad
diff --git a/charm/launchpad/metadata.yaml b/charm/launchpad/metadata.yaml
deleted file mode 100644
index 3dbf9a9..0000000
--- a/charm/launchpad/metadata.yaml
+++ /dev/null
@@ -1,13 +0,0 @@
-name: launchpad
-display-name: launchpad
-summary: Launchpad web application
-maintainer: Launchpad Developers <launchpad-dev@xxxxxxxxxxxxxxxxxxx>
-description: |
-  Launchpad is an open source suite of tools that help people and teams
-  to work together on software projects.
-tags:
-  # https://juju.is/docs/charm-metadata#heading--charm-store-fields
-  - network
-series:
-  - focal
-subordinate: false
diff --git a/charm/launchpad/reactive/launchpad.py b/charm/launchpad/reactive/launchpad.py
deleted file mode 100644
index 5b4222b..0000000
--- a/charm/launchpad/reactive/launchpad.py
+++ /dev/null
@@ -1,17 +0,0 @@
-# Copyright 2022 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-
-from charmhelpers.core import hookenv
-from charms.reactive import set_state, when, when_not
-
-
-@when("ols.configured")
-@when_not("service.configured")
-def configure():
-    hookenv.log("Hello world!")
-    set_state("service.configured")
-
-
-@when("service.configured")
-def check_is_running():
-    hookenv.status_set("active", "Ready")

Follow ups