launchpad-reviewers team mailing list archive

[Ines Almeida <mp+453216@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, just a small question

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index c3b40ce..c601076 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -38,7 +41,7 @@
>  {%-   set openstack_username_lcy02 = "launchpad-vbuilder-production" %}
>  {%-   set vbuilders_bos01 = {"amd64": {"series": "focal", "flavor": "vbuilder-gpu", "count": 5}, "arm64": {"series": "focal", "count": 40, "config_drive": false}, "arm64-gpu": {"arch_base": "arm64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-nvidia-l4", "count": 2, "config_drive": false}, "ppc64el": {"series": "focal", "count": 20}, "s390x": {"series": "focal", "count": 20}} %}
>  {%-   set vbuilders_bos02 = {"arm64": {"series": "focal", "count": 80, "config_drive": false}, "ppc64el": {"series": "focal", "count": 30}, "s390x": {"series": "focal", "count": 20}} %}
> -{%-   set vbuilders_bos03 = {"amd64": {"series": "focal", "count": 60}} %}
> +{%-   set vbuilders_bos03 = {"amd64": {"series": "focal", "count": 60}, "riscv64": {"series": "jammy", "count": 60, "config_drive": false}} %}

Why didn't we have 'riscv64' initially in qastaging?

>  {%-   set vbuilders_lcy02 = {"amd64": {"series": "focal", "count": 120}} %}
>  {%-   set vbuilder_prefix = "" %}
>  {%- elif stage_name == "staging" %}


-- 
https://code.launchpad.net/~cjwatson/launchpad-mojo-specs/+git/private/+merge/453216
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.