launchpad-reviewers team mailing list archive

[Ines Almeida <mp+453932@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py
> index a9a0128..42c1cee 100644
> --- a/lib/lp/snappy/model/snap.py
> +++ b/lib/lp/snappy/model/snap.py
> @@ -675,6 +679,18 @@ class Snap(StormBase, WebhookTargetMixin):
>      def store_channels(self, value):
>          self._store_channels = value or None
>  
> +    # XXX ines-almeida 2023-10-18: Simplify this once the database column has

@cjwatson, a couple of these comments were originally yours from your draft and I was going to keep them, but I decided to change them to me in case we look at them after November

> +    # been backfilled.
> +    @property
> +    def pro_enable(self):
> +        if self._pro_enable is None:
> +            return getUtility(ISnapSet).inferProEnable(self.source)
> +        return self._pro_enable
> +
> +    @pro_enable.setter
> +    def pro_enable(self, value):
> +        self._pro_enable = value
> +
>      def getAllowedInformationTypes(self, user):
>          """See `ISnap`."""
>          if user_has_special_snap_access(user):


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/453932
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:pro-enable-core18/update-models into launchpad:master.