launchpad-reviewers team mailing list archive

[Ines Almeida <mp+454273@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:pro-enable-core18/fix-unit-tests into launchpad:master.

Commit message:
Fix failing pro-enable unit test

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/454273

Another one to fix. Apparently I had missed merging in some test updates in my initial MP. These extra asserts are not necessary at all and don't make sense
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:pro-enable-core18/fix-unit-tests into launchpad:master.

diff --git a/lib/lp/snappy/tests/test_snap.py b/lib/lp/snappy/tests/test_snap.py
index 14fda0d..5675585 100644
--- a/lib/lp/snappy/tests/test_snap.py
+++ b/lib/lp/snappy/tests/test_snap.py
@@ -309,13 +309,9 @@ class TestSnap(TestCaseWithFactory):
             return
 
         self.assertTrue(snaps[0].pro_enable)  # Snap with no base
-        self.assertTrue(removeSecurityProxy(snaps[0])._pro_enable)
         self.assertTrue(snaps[1].pro_enable)  # Snap with 'core' base
-        self.assertTrue(removeSecurityProxy(snaps[1])._pro_enable)
         self.assertFalse(snaps[2].pro_enable)  # Snap with 'core18' base
-        self.assertFalse(removeSecurityProxy(snaps[2])._pro_enable)
         self.assertFalse(snaps[3].pro_enable)  # Snap without snapcraft.yaml
-        self.assertFalse(removeSecurityProxy(snaps[3])._pro_enable)
 
     def makeBuildableDistroArchSeries(self, **kwargs):
         das = self.factory.makeDistroArchSeries(**kwargs)