launchpad-reviewers team mailing list archive

[Colin Watson <mp+455048@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:invent-kde-org-blobs into launchpad:master.

Commit message:
Support fetching blobs from repositories on invent.kde.org

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #2040260 in Launchpad itself: "snap recipe is ignoring series: infer from snapcraft.yaml"
  https://bugs.launchpad.net/launchpad/+bug/2040260

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/455048
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:invent-kde-org-blobs into launchpad:master.

diff --git a/lib/lp/code/model/gitref.py b/lib/lp/code/model/gitref.py
index 240e604..9abe5d1 100644
--- a/lib/lp/code/model/gitref.py
+++ b/lib/lp/code/model/gitref.py
@@ -968,11 +968,14 @@ def _fetch_blob_from_gitlab(repository_url, ref_path, filename):
 
 
 # Some well-known GitLab instances.  This is certainly not comprehensive.
+# XXX cjwatson 2023-11-02: This should probably use a feature rule so that
+# it can be extended more easily.
 _gitlab_hostnames = {
     "gitlab.com",
     "gitlab.eclipse.org",
     "gitlab.freedesktop.org",
     "gitlab.gnome.org",
+    "invent.kde.org",
     "salsa.debian.org",
 }