launchpad-reviewers team mailing list archive

[Ines Almeida <mp+455770@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/txpkgupload:remove-passive-ftp-ports-from-sftp-haproxy-config into txpkgupload:master.

Commit message:
Remove passive ftp ports from sftp haproxy config

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/txpkgupload/+git/txpkgupload/+merge/455770
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/txpkgupload:remove-passive-ftp-ports-from-sftp-haproxy-config into txpkgupload:master.

diff --git a/charm/txpkgupload/reactive/txpkgupload.py b/charm/txpkgupload/reactive/txpkgupload.py
index bb22539..f0d5de6 100644
--- a/charm/txpkgupload/reactive/txpkgupload.py
+++ b/charm/txpkgupload/reactive/txpkgupload.py
@@ -251,7 +251,6 @@ def configure_loadbalancer():
             f"{config['min_passive_port']}-{config['max_passive_port']}"
         )
         service_options_ftp.append(extra_ports)
-        service_options_sftp.append(extra_ports)
 
     ftp_port = config["ftp_port"]
     sftp_port = config["sftp_port"]