launchpad-reviewers team mailing list archive

[Colin Watson <mp+453586@xxxxxxxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/registry/interfaces/distroseries.py b/lib/lp/registry/interfaces/distroseries.py
> index bcb5a24..d27ac20 100644
> --- a/lib/lp/registry/interfaces/distroseries.py
> +++ b/lib/lp/registry/interfaces/distroseries.py
> @@ -585,6 +585,17 @@ class IDistroSeriesPublic(
>          as_of="devel",
>      )
>  
> +    publish_i18n_index = exported(
> +        Bool(
> +            title=_("Publish I18n index"),
> +            required=True,
> +            description=_(
> +                """
> +            Publish archive i18n/Index file, which is believed to be used."""

Was this meant to say "which is believed to be unused"?

> +            ),
> +        )
> +    )
> +
>      inherit_overrides_from_parents = Bool(
>          title=_("Inherit overrides from parents"),
>          readonly=False,


-- 
https://code.launchpad.net/~xnox/launchpad/+git/launchpad/+merge/453586
Your team Launchpad code reviewers is requested to review the proposed merge of ~xnox/launchpad:drop-i18n-index into launchpad:master.