launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master

To: Simone Pelosi <simone.pelosi@xxxxxxxxxxxxx>
From: Ines Almeida <mp+457527@xxxxxxxxxxxxxxxxxx>
Date: Fri, 15 Dec 2023 15:55:20 -0000
In-reply-to: <170254663871.1708664.14569769467145806817.launchpad@juju-98d295-prod-launchpad-17>
Reply-to: mp+457527@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

>From my initial look it looks generally good to me, just a few comments.
Also, as you had already mentioned, we will need to add more tests :)

Will get back to it and do a more in depth review in 2024 after the break!
-- 
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/457527
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master.

References

[Merge] ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master
From: Simone Pelosi, 2023-12-14