launchpad-reviewers team mailing list archive

[Ines Almeida <mp+457880@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:db-add-social-accounts-table into launchpad:db-devel.

Commit message:
db: add DB table permissions to person-merge-job profile

Requested reviews:
  William Grant (wgrant): db
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/457880

A few unit tests are still failing due to table permissions for the new socialaccounts table.

Looking through the failing tests, apart from a few intermittent failures, they seem to come mostly from the person merge job. I tested a handful of the failing tests locally

-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:db-add-social-accounts-table into launchpad:db-devel.

diff --git a/database/schema/security.cfg b/database/schema/security.cfg
index ba96238..5407957 100644
--- a/database/schema/security.cfg
+++ b/database/schema/security.cfg
@@ -2459,6 +2459,7 @@ public.snapbase                         = SELECT, UPDATE
 public.snapbuild                        = SELECT, UPDATE
 public.snapsubscription                 = SELECT, UPDATE, DELETE
 public.snappyseries                     = SELECT, UPDATE
+public.socialaccount                    = SELECT, INSERT, UPDATE
 public.sourcepackagename                = SELECT
 public.sourcepackagepublishinghistory   = SELECT, UPDATE
 public.sourcepackagerecipe              = SELECT, UPDATE