launchpad-reviewers team mailing list archive

[Dimitri John Ledkov <mp+447665@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~xnox/launchpad:snap-request-builds-mimick-auto into launchpad:master has been updated.

Commit message changed to:

snappy: Make requestbuild use auto-build archive and pocket defaults

Make request snap builds page for a snap, reuse auto-build archive & pocket, if set on the snap.

Rationale:
* Currently many snap builds are only correct, or successful if they use a predetermined set of snap recipe configuration. For example - beta channel recipe, uses beta PPA archive to pull in relevant beta .deb dependencies. Or for example use special forked dependencies from a given private archive (for pre-release or edge builds). Especially when such archives cannot be encoded in the snapcraft.yaml (as they are either private, or need to be dynamically updated to one of multiple valid options, depending on upload target).
* Auto-builds are able to correctly set desired auto-build archive, and it is correctly used
* When triggering a manual build, currently the default auto-build settings are not used. Meaning one has to carefully inspect snap recipe auto-build settings and lookup matching build archive and set it on the request snap build page to ensure the manual triggered build is done the same way as the automatically triggered one
* Fix this UI/UX issue by pre-populating manually triggered build, with the same defaults that automaticly triggered builds use. Such that for example the same build archive is used.

QAStaging test case:
* Create snap recipe
* Set it to autobuild
* Set a PPA archive for autobuilds
* Click Requests Builds
* The UI page of requests builds should have the same autobuild PPA prepulated and selected

LP: #2028687

For more details, see:
https://code.launchpad.net/~xnox/launchpad/+git/launchpad/+merge/447665
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~xnox/launchpad:snap-request-builds-mimick-auto into launchpad:master.