launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+458930@xxxxxxxxxxxxxxxxxx>]

I wonder why such a simple test could take more than 30 seconds.

I did not have a closer look, just two points of thoughts:
- Are we ok that our test suite gets longer? It is only another 30 seconds, but still, I think 30 or even 60 seconds for a simple test are pretty crazy. Should we rather check whether we could cut down the time of the test?
- When changing the test, and we are ok when things take longer, does that also mean we are ok when things on production take longer?
-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458930
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:increase-unittest-fetch-timeout into launchpad:master.