launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+460488@xxxxxxxxxxxxxxxxxx>]

Simone Pelosi has proposed merging ~pelpsi/launchpad:copy-archive-publisher-missing-umask into launchpad:master.

Commit message:
Add umask 022 before publish-ftpmaster.py call
    
umask 022 is required to fix the following error:
`Queue item ignored: Bad umask; expected 022, got 002`

Support request: 
https://chat.canonical.com/canonical/pl/uidssikjuiby5ja5p189cjz15y

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/460488
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:copy-archive-publisher-missing-umask into launchpad:master.

diff --git a/charm/launchpad-copy-archive-publisher/templates/crontab.j2 b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
index 99eb759..bf2502b 100644
--- a/charm/launchpad-copy-archive-publisher/templates/crontab.j2
+++ b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
@@ -4,7 +4,7 @@ MAILTO={{ cron_mailto }}
 LPCONFIG=launchpad-copy-archive-publisher
 
 {% if active -%}
-*/5 * * * * {{ code_dir }}/cronscripts/publish-ftpmaster.py --all-derived -vv >> {{ logs_dir }}/derived-publish-ftpmaster.log 2>&1
+*/5 * * * * umask 022; {{ code_dir }}/cronscripts/publish-ftpmaster.py --all-derived -vv >> {{ logs_dir }}/derived-publish-ftpmaster.log 2>&1
 
 10 */6 * * * {{ code_dir }}/scripts/process-death-row.py --all-derived -q --log-file=DEBUG:{{ logs_dir }}/derived-process-death-row.log