launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+460664@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-bad-umask-error into launchpad:master.

Commit message:
Fix missing umask call

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/460664

A previous attempt to fix this issue was applied to a script where umask was also missing, but that did not fix the issue.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:fix-bad-umask-error into launchpad:master.

diff --git a/charm/launchpad-copy-archive-publisher/templates/crontab.j2 b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
index bf2502b..4b7e7d4 100644
--- a/charm/launchpad-copy-archive-publisher/templates/crontab.j2
+++ b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
@@ -8,7 +8,7 @@ LPCONFIG=launchpad-copy-archive-publisher
 
 10 */6 * * * {{ code_dir }}/scripts/process-death-row.py --all-derived -q --log-file=DEBUG:{{ logs_dir }}/derived-process-death-row.log
 
-22 * * * * {{ base_dir }}/bin/cron.publish-copy-archives.sh >> {{ logs_dir }}/cron.publish-copy-archives.log 2>&1
+22 * * * * umask 022; {{ base_dir }}/bin/cron.publish-copy-archives.sh >> {{ logs_dir }}/cron.publish-copy-archives.log 2>&1
 
 15 * * * * nice -n 12 ionice -c 2 -n 7 {{ code_dir }}/cronscripts/ppa-generate-keys.py --copy-archives -q --log-file=INFO:{{ logs_dir }}/generate-keys-copy-archives.log
 {%- endif %}