launchpad-reviewers team mailing list archive

[Ines Almeida <mp+460812@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:frontpage-revamp-remove-old-blog-post into launchpad:master.

Commit message:
Remove old pinned blog post from homepage

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460812

This removes the pinned blog post from 2009, which gives the impression that we are not that active in our blog since we have a post from 2009 in our recent posts.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:frontpage-revamp-remove-old-blog-post into launchpad:master.

diff --git a/lib/lp/app/browser/tests/test_launchpadroot.py b/lib/lp/app/browser/tests/test_launchpadroot.py
index 85faf0a..9d81273 100644
--- a/lib/lp/app/browser/tests/test_launchpadroot.py
+++ b/lib/lp/app/browser/tests/test_launchpadroot.py
@@ -182,13 +182,7 @@ class LaunchpadRootIndexViewTestCase(TestCaseWithFactory):
         self.assertEqual(["called"], calls)
         items = markup.find_all("li", "news")
         # Notice about launchpad being opened is always added at the end
-        self.assertEqual(3, len(items))
-        a = items[-1].find("a")
-        self.assertEqual("Launchpad now open source", a.string.strip())
-        for post, item in zip(posts, items):
-            a = item.find("a")
-            self.assertEqual(post["link"], a["href"])
-            self.assertEqual(post["title"], a.string)
+        self.assertEqual(2, len(items))
 
     def test_blog_disabled(self):
         """Launchpad blog not queried for display without feature"""
@@ -228,7 +222,7 @@ class LaunchpadRootIndexViewTestCase(TestCaseWithFactory):
             result, parse_only=SoupStrainer(id="homepage-blogposts")
         )
         items = markup.find_all("li", "news")
-        self.assertEqual(3, len(items))
+        self.assertEqual(2, len(items))
 
     def test_featured_projects_query_count(self):
         def add_featured_projects():
diff --git a/lib/lp/app/templates/root-index.pt b/lib/lp/app/templates/root-index.pt
index 75084b9..da9fac2 100644
--- a/lib/lp/app/templates/root-index.pt
+++ b/lib/lp/app/templates/root-index.pt
@@ -128,11 +128,6 @@
                   our short survey.
                 </tal:description>
                 </li>
-                <li class="news">
-                  <a href="http://blog.launchpad.net/general/launchpad-is-now-open-source";>
-                    Launchpad now open source</a><span class="registered"> &ndash; 21 Jul 2009</span><br />
-                    Get the code to Launchpad and join our development community.
-                </li>
               </ul>
               <ul class="horizontal">
                 <li>