launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #30886
Re: [Merge] ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project
Diff comments:
> diff --git a/lib/lp/app/templates/root-index.pt b/lib/lp/app/templates/root-index.pt
> index ee51d55..2a6ffcf 100644
> --- a/lib/lp/app/templates/root-index.pt
> +++ b/lib/lp/app/templates/root-index.pt
> @@ -6,48 +6,7 @@
> metal:use-macro="view/macro:page/main_only"
> i18n:domain="launchpad">
> <metal:head fill-slot="head_epilogue">
> - <style>
> - .homepage {
> - margin: auto;
> - width: 90%;
> - max-width: 80em;
> - }
> - #homepage-whatslaunchpad ul {
> - margin-left: 1em;
> - margin-bottom: 0.5em;
> - }
> - #homepage-whatslaunchpad ul,
> - #homepage-whatslaunchpad-tour {
> - font-weight: bold;
> - }
> - #homepage-stats {
> - max-width: 50em;
> - margin: auto;
> - padding-top: 0.5em;
> - color: gray;
> - }
> - #homepage-blogposts {
> - padding-right: 4em;
> - }
> - #homepage-getstarted ul {
> - padding-top: 0.5em;
> - }
> - .featured-project-top h3 {
> - font-weight: bold;
> - }
> - .featured-project-top h3 img {
> - vertical-align: middle;
> - }
> - .featured-project-top p {
> - margin-top: 0.5em;
> - margin-bottom: 1em;
> - padding-bottom: .5em;
> - border-bottom: 1px dotted #999;
> - }
> - #launchpad-logo-and-name {
> - width: 250px;
> - }
> - </style>
> + <link rel="stylesheet" href="https://assets.ubuntu.com/v1/vanilla-framework-version-4.7.0.min.css"; />
I would prefer vendoring this file in the Launchpad tree, like we do for all other fronted dependencies, instead of relying on an external URL/service.
> </metal:head>
> <body>
> <div metal:fill-slot="main">
> @@ -67,90 +26,26 @@
> style="margin: 0 9em 1em 0"/>
> </div>
>
> - <div class="yui-g">
> - <div class="yui-u first" style="margin-top: 1.5em;">
> - <div class="homepage-whatslaunchpad"
> - tal:condition="view/show_whatslaunchpad">
> - <h2><span class="launchpad-gold">Launchpad</span> is a software collaboration platform that provides:</h2>
> - <ul tal:define="apphomes view/apphomes">
> - <li>
> - <a class="sprite bug"
> - tal:attributes="href apphomes/bugs">Bug tracking</a>
> - </li>
> - <li>
> - <a class="sprite branch"
> - tal:attributes="href apphomes/code">Code hosting</a>
> - using <a href="http://bazaar.canonical.com/";>Bazaar</a>
> - and <a href="https://git-scm.com/";>Git</a>
> - </li>
> - <li>
> - <a class="sprite yes"
> - href="https://help.launchpad.net/Code/Review";>Code reviews</a>
> - </li>
> - <li>
> - <a class="sprite ubuntu-logo"
> - tal:attributes="href apphomes/ubuntu">Ubuntu package building and hosting</a>
> - </li>
> - <li>
> - <a class="sprite translate-icon"
> - tal:attributes="href apphomes/translations">Translations</a>
> - </li>
> - <li>
> - <a class="sprite mail"
> - href="https://help.launchpad.net/Teams/MailingLists";>Mailing lists</a>
> - </li>
> - <li>
> - <a class="sprite question"
> - tal:attributes="href apphomes/answers">Answer tracking and FAQs</a>
> - </li>
> - <li>
> - <a class="sprite blueprint"
> - tal:attributes="href apphomes/blueprints">Specification tracking</a>
> - </li>
> - </ul>
> - <div id="homepage-whatslaunchpad-tour">
> - <a class="sprite tour" href="/+tour">Take the tour!</a>
> - </div>
> - </div>
> -
> - <div id="homepage-blogposts" class="homepage-portlet"
> - tal:condition="features/app.root_blog.enabled">
> - <h2>Recent Launchpad blog posts</h2>
> - <ul tal:define="posts view/getRecentBlogPosts">
> - <li class="news"
> - tal:repeat="post posts">
> - <a href="" tal:attributes="href post/link"
> - tal:content="post/title">
> - Take the Launchpad survey</a><span class="registered">
> - – <tal:date content="post/date">01 July 2010</tal:date></span><br />
> - <tal:description content="structure post/description">
> - Tell us a little about how you use Launchpad by answering
> - our short survey.
> - </tal:description>
> - </li>
> - </ul>
> - <ul class="horizontal">
> - <li>
> - <strong><a href="http://blog.launchpad.net";>Read the blog</a></strong>
> - </li>
> - </ul>
> - </div>
> - </div>
> -
> - <div class="yui-u">
> - <form id="homepage-searchform"
> + <section class="p-strip is-shallow">
> + <div class="u-fixed-width">
> + <form id="homepage-searchform" class="p-form p-form--inline"
> xml:lang="en" lang="en" dir="ltr"
> tal:attributes="action string:${rooturl}+search"
> method="get" accept-charset="UTF-8">
> - <input id="text" type="text" name="field.text" size="25" />
> - <input id="search" type="submit" value="Search Launchpad" />
> + <div class="p-form__group p-form--search">
> + <label for="search-input" class="u-off-screen">Search</label>
> + <div class="p-form__control u-clearfix">
> + <input id="search-input" type="search" name="field.text" value="" autofocus="">
> + </div>
> + </div>
> + <button id="search" class="p-button--positive" type="submit" value="Search">Search</button>
Now that we are placing a lot of emphasis on the search, we have to fix the broken search soon. :)
> </form>
> <script type="text/javascript">
> LPJS.use('lp', function () {
> setFocusByName('field.text');
> });
> </script>
> - <div id="homepage-stats">
> + <div id="homepage-stats" class="u-text--muted">
> <strong
> tal:content="view/project_count/fmt:intcomma">123</strong> projects,
> <strong
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project.
