launchpad-reviewers team mailing list archive

[Ines Almeida <mp+460966@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> new file mode 100644
> index 0000000..2811116
> --- /dev/null
> +++ b/lp-fetch-service/bundle.yaml
> @@ -0,0 +1,22 @@
> +{%- if stage_name == "production" %}
> +{%-   set devel = False %}
> +{%- elif stage_name == "staging" %}
> +{%-   set devel = False %}
> +{%- else %}
> +{%-   set devel = True %}
> +{%- endif -%}
> +
> +series: jammy
> +applications:
> +{%- if devel or stage_name == "staging" %}

> It is probably just as straightforward as not to define the fetch service for production?

That is exactly what the code is doing here: it only defines the fetch-service if `devel` (local) or `staging`.

----

I can't edit the comment above, but what it meant is that in the particular case that someone by accident deploys this mojo spec in production (which is not supposed to happen), it will throw an error because there is no application defined (i.e., the list if application when the "stage_name" is production is empty). But IMO it's OK to have that error

> +  fetch-service:
> +    {#- While the fetch-service charm and snap are not public, we are deploying
> +        a locally built charm. The lines below should be replaced with the path
> +        to charmhub, channel and revision number once the charm and snap are
> +        public. Currently, this expects the charm and snap to be copied to the
> +        path where the bundle.yaml is rendered, in the mojo project folder (eg.
> +        .../mojo/lp-fetch-service/jammy/devel/charms/lp-fetch-service/). #}
> +    charm: "./fetch-service_ubuntu-22.04-amd64.charm"
> +    resources:
> +      snap: "./fetch-service.snap"
> +{%- endif %}


-- 
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/460966
Your team Launchpad code reviewers is subscribed to branch ~ines-almeida/launchpad-mojo-specs/+git/private:lp-fetch-service.