launchpad-reviewers team mailing list archive

[Ines Almeida <mp+463030@xxxxxxxxxxxxxxxxxx>]

LGTM! Just a very small suggestion.

I was wondering if there are any tests to update or add, but maybe not since this new model attribute isn't really used yet - we'll do it when adding APIs/UI.

Note that this cannot be merged until the DB change is deployed to production. I'm happy to approve this one, but I won't for now because of that :)

Diff comments:

> diff --git a/lib/lp/soyuz/interfaces/archive.py b/lib/lp/soyuz/interfaces/archive.py
> index e1521ce..cc48143 100644
> --- a/lib/lp/soyuz/interfaces/archive.py
> +++ b/lib/lp/soyuz/interfaces/archive.py
> @@ -1021,6 +1021,8 @@ class IArchiveView(IHasBuildRecords):
>          "pending publications."
>      )
>  
> +    metada_overrides = Attribute("A dict of data about the archive.")

"A dict of data" sounds a little bit generic IMO, how about "An object containing metadata overrides for this archive." or something along those lines?

> +
>      processors = exported(
>          CollectionField(
>              title=_("Processors"),


-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/463030
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:feat-archive-metadata-overrides into launchpad:master.