launchpad-reviewers team mailing list archive

[Ines Almeida <mp+464017@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:change-appserver-log-rotate into launchpad:master.

Commit message:
charm: update appserver logrotate from daily to hourly
    
Currently log files for this service can get quite heavy (in the realm of 10 Gb) which makes it impossible to live view the latest logs of a unit. Taking into account that we run 4 appserver units, debuging an issue can lead to several minutes to download the daily log files, and the launchpad-bastion disk to get unnecessarily full.
In this change, we are rotating the logs hourly, while keeping the same amount of days worth of logs on disk. This will lead to lighter log files, and less space for logs used.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464017

This is currently running in qastaging (changed manually) for testing
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:change-appserver-log-rotate into launchpad:master.

diff --git a/charm/launchpad-appserver/templates/logrotate.conf.j2 b/charm/launchpad-appserver/templates/logrotate.conf.j2
index 494f246..2714525 100644
--- a/charm/launchpad-appserver/templates/logrotate.conf.j2
+++ b/charm/launchpad-appserver/templates/logrotate.conf.j2
@@ -1,8 +1,9 @@
 {{ logs_dir }}/launchpad.log
 {
-    rotate 21
-    daily
+    rotate 504
+    hourly
     dateext
+    dateformat -%Y%m%d-%H
     delaycompress
     compress
     notifempty