launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+464121@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/lpci:add-support-for-noble into lpci:main.

Commit message:
Add support for noble

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/lpci/+git/lpcraft/+merge/464121

And remove one overlooked reference to lunar.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/lpci:add-support-for-noble into lpci:main.

diff --git a/NEWS.rst b/NEWS.rst
index 4fd49c9..867dd2c 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -7,6 +7,7 @@ Version history
 
 - Remove support for Lunar, which EOLed January 2024.
 - Update dependencies to add support for new lxd version schema.
+- Add support for 24.04 (noble).
 
 0.2.6 (2024-02-19)
 ==================
diff --git a/lpci/providers/_buildd.py b/lpci/providers/_buildd.py
index 07fd876..5849def 100644
--- a/lpci/providers/_buildd.py
+++ b/lpci/providers/_buildd.py
@@ -19,6 +19,7 @@ SERIES_TO_BUILDD_IMAGE_ALIAS = {
     "focal": bases.BuilddBaseAlias.FOCAL,
     "jammy": bases.BuilddBaseAlias.JAMMY,
     "mantic": bases.BuilddBaseAlias.MANTIC,
+    "noble": bases.BuilddBaseAlias.NOBLE,
     "devel": bases.BuilddBaseAlias.DEVEL,
 }
 
diff --git a/lpci/providers/tests/test_buildd.py b/lpci/providers/tests/test_buildd.py
index 5f11a11..0f0e659 100644
--- a/lpci/providers/tests/test_buildd.py
+++ b/lpci/providers/tests/test_buildd.py
@@ -22,11 +22,10 @@ class TestLPCIBuilddBaseConfiguration(TestCase):
             "18.04": BuilddBaseAlias.BIONIC.value,
             "20.04": BuilddBaseAlias.FOCAL.value,
             "22.04": BuilddBaseAlias.JAMMY.value,
-            "23.04": BuilddBaseAlias.LUNAR.value,
             "23.10": BuilddBaseAlias.MANTIC.value,
+            "24.04": BuilddBaseAlias.NOBLE.value,
             "devel": BuilddBaseAlias.DEVEL.value,
         }
         for k, v in alias_mapping.items():
             self.assertEqual(k, v)
-
         self.assertEqual(len(BuilddBaseAlias), len(alias_mapping))