← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master

 

Fixed all mypy issues (interestingly, some of them were issues that already existed in the code previously, but weren't an issue before), and added comments where it was relevant.

I will refrain from adding unit tests in this MP since the functionality seems to be highly tested between the multiple tests that contain `extraBuildArgs` and all the tests within `lp.snappy.tests.test_snapbuildbehaviour`.
-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464303
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master.



References