launchpad-reviewers team mailing list archive

[Ines Almeida <mp+464639@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/snappy/interfaces/snapbuild.py b/lib/lp/snappy/interfaces/snapbuild.py
> index 52019bf..fea9d5f 100644
> --- a/lib/lp/snappy/interfaces/snapbuild.py
> +++ b/lib/lp/snappy/interfaces/snapbuild.py
> @@ -370,6 +371,14 @@ class ISnapBuildView(IPackageBuildView, IPrivacy):
>  
>          :return: A collection of URLs for this build."""
>  
> +    @export_operation_as("build_metadata_url")

As mentioned in the previous diff, this is being exported as a method, which makes it odd that it's named as an attribute. I think we either export it as `getBuildMetadataUrl()` (name of the method), or export it as an attribute. But calling `build.build_metadata_url()` when we use this in `lp-shell` is not coherent.

> +    @export_read_operation()
> +    @operation_for_version("devel")
> +    def getBuildMetadataUrl():
> +        """URL of the metadata file generated by the fetch service
> +
> +        :return: URL of the metadata if present."""
> +
>  
>  class ISnapBuildEdit(IBuildFarmJobEdit):
>      """`ISnapBuild` attributes that require launchpad.Edit."""


-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/464639
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master.