launchpad-reviewers team mailing list archive

[Ines Almeida <mp+464751@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/snappy/model/snapbuild.py b/lib/lp/snappy/model/snapbuild.py
> index c7418e6..0fc5d16 100644
> --- a/lib/lp/snappy/model/snapbuild.py
> +++ b/lib/lp/snappy/model/snapbuild.py
> @@ -663,6 +663,10 @@ class SnapBuildSet(SpecificBuildFarmJobSourceMixin):
>              )
>          load_related(Job, sbjs, ["job_id"])
>  
> +        # Prefetch snap files

I'm not 100% sure about this. Regarding query counts, it didn't seem to have an effect. I added it as a commit that I can revert, but I'd like comments on this if there is any.

> +        snap_files = load_referencing(SnapFile, builds, ["snapbuild_id"])
> +        load_related(LibraryFileAlias, snap_files, ["libraryfile_id"])
> +
>      def getByBuildFarmJobs(self, build_farm_jobs):
>          """See `ISpecificBuildFarmJobSource`."""
>          if len(build_farm_jobs) == 0:


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464751
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-update-build-metadata-url into launchpad:master.