launchpad-reviewers team mailing list archive

[Ines Almeida <mp+465326@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~ines-almeida/launchpad:fetch-service-redact-certificate-in-logs into launchpad:master has been updated.

Description changed to:

Tests from CIBuilds that tested the redacted secrets still ran successfully.

No other build type has `secrets` in their args except for snap builds and ci builds, but IMO anything that goes under a "secrets" keywords should be redacted - so I updated it within the parent `redactXmlrpcArguments` method.

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465326
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-redact-certificate-in-logs into launchpad:master.